[libc-commits] [PATCH] D72102: [libc] Add __attribute__((always_inline)) to x86_64 syscall functions.

[Michael Schellenberger Costa via Phabricator via libc-commits]

miscco marked an inline comment as done.
miscco added a comment.

clang-format comment



================
Comment at: libc/config/linux/x86_64/syscall.h.inc:90
       "=a"(retcode) :
       "a"(__number), "D"(__arg1), "S"(__arg2), "d"(__arg3), "r"(r10), "r"(r8), "r"(r9) :
       SYSCALL_CLOBBER_LIST);
----------------
abrachet wrote:
> sivachandra wrote:
> > abrachet wrote:
> > > Ditto to `clang-format` this line is too long.
> > I do run clang-format with every change. However, since the names of these files do not end in `.h`, clang-format ignores them. I will play with renaming these files just to get clang-format to look at them, and then revert to the old name. Will do so in different change.
> Thats a pain. It looks like there is an `--assume-filename=<string>` flag, I haven't used this yet but maybe that would be easier? https://clang.llvm.org/docs/ClangFormat.html
For what its worth Microsofts STL uses a default vscode [[ https://github.com/microsoft/STL/blob/master/.vscode/settings.json#L5 | setting ]].

I am quite sure that you can set similar options for whatever IDE / editor you use.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72102/new/

https://reviews.llvm.org/D72102