[libc-commits] [PATCH] D72102: [libc] Add __attribute__((always_inline)) to x86_64 syscall functions.

[Alex Brachet via Phabricator via libc-commits]

abrachet accepted this revision.
abrachet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/config/linux/x86_64/syscall.h.inc:17
 
-inline long syscall(long __number) {
+__attribute__((always_inline)) inline long syscall(long __number) {
   long retcode;
----------------
I guess `inline` isn't necessary to keep anymore?


================
Comment at: libc/config/linux/x86_64/syscall.h.inc:81
+__attribute__((always_inline)) inline long syscall(
+    long __number, long __arg1,long __arg2, long __arg3, long __arg4,
+    long __arg5, long __arg6) {
----------------
No space here `__arg1,long` it looks like. I suggest just running `clang-format`.


================
Comment at: libc/config/linux/x86_64/syscall.h.inc:90
       "=a"(retcode) :
       "a"(__number), "D"(__arg1), "S"(__arg2), "d"(__arg3), "r"(r10), "r"(r8), "r"(r9) :
       SYSCALL_CLOBBER_LIST);
----------------
Ditto to `clang-format` this line is too long.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72102/new/

https://reviews.llvm.org/D72102