[libc-commits] [PATCH] D75026: [libc] Add sigprocmask

[Fangrui Song via Phabricator via libc-commits]

MaskRay added inline comments.


================
Comment at: libc/src/signal/linux/sigaddset.cpp:19
+int LLVM_LIBC_ENTRYPOINT(sigaddset)(sigset_t *set, int signum) {
+  if (!set || (unsigned)signum > (8 * sizeof(sigset_t))) {
+    llvmlibc_errno = EINVAL;
----------------
abrachet wrote:
> MaskRay wrote:
> > `_NSIG` is expected to be compared.
> `_NSIG`'s value has still not been decided, so I didn't want to use it. Should I just go ahead and define it as 65?
This is a good example of layering issue. `_NSIG` is not decided yet (for no good reasons. I think we don't care about MIPS, at least for a forseeable future) => so we don't use it in this patch => this patch gets approved => it is committed.

Someday we add `_NSIG` => the patch needs rework.

(Well, doing things this way can cause a large number of commits. If someone judges the contribution by just counting the number of commits....)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75026/new/

https://reviews.llvm.org/D75026