[libc-commits] [PATCH] D75136: [libc] Fix build when -DBUILD_SHARED_LIBS=On

[Guillaume Chatelet via Phabricator via libc-commits]

gchatelet added a comment.

Hmm it still doesn't seem to work

My command line:

  cmake -DCMAKE_C_COMPILER=/usr/bin/gcc -DCMAKE_CXX_COMPILER=/usr/bin/g++ -DCMAKE_BUILD_TYPE=Debug -LLVM_ENABLE_ASSERTIONS=ON -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DLLVM_USE_SPLIT_DWARF=ON -DLLVM_OPTIMIZED_TABLEGEN=ON -DLLVM_TARGETS_TO_BUILD=X86 -DLLVM_ENABLE_PROJECTS=libc -DBUILD_SHARED_LIBS=ON -DLLVM_BUILD_TESTS=ON -DLLVM_ENABLE_WERROR=ON -DLLVM_ENABLE_LLD=ON -H/redacted/git/llvm-project/llvm -B/tmp/llvm-project_dbg_compiled-with-gcc -GNinja



  FAILED: lib/libLibcUnitTest.so.11git 
  : && /usr/bin/g++ -fPIC -fPIC -fvisibility-inlines-hidden -Werror -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -fdiagnostics-color -g  -Wl,-z,defs -Wl,-z,nodelete -fuse-ld=lld -Wl,--color-diagnostics -shared -Wl,-soname,libLibcUnitTest.so.11git -o lib/libLibcUnitTest.so.11git projects/libc/utils/UnitTest/CMakeFiles/LibcUnitTest.dir/Test.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib" lib/libLLVMSupport.so.11git && :
  ld.lld: error: undefined symbol: __llvm_libc::testutils::invokeInSubprocess(__llvm_libc::testutils::FunctionCaller*)
  >>> referenced by Test.cpp:238 (/redacted/git/llvm-project/libc/utils/UnitTest/Test.cpp:238)
  >>>               projects/libc/utils/UnitTest/CMakeFiles/LibcUnitTest.dir/Test.cpp.o:(__llvm_libc::testing::Test::testProcessKilled(__llvm_libc::testing::RunContext&, __llvm_libc::testutils::FunctionCaller*, int, char const*, char const*, char const*, unsigned long))
  >>> referenced by Test.cpp:269 (/redacted/git/llvm-project/libc/utils/UnitTest/Test.cpp:269)
  >>>               projects/libc/utils/UnitTest/CMakeFiles/LibcUnitTest.dir/Test.cpp.o:(__llvm_libc::testing::Test::testProcessExits(__llvm_libc::testing::RunContext&, __llvm_libc::testutils::FunctionCaller*, int, char const*, char const*, char const*, unsigned long))
  
  ld.lld: error: undefined symbol: __llvm_libc::testutils::ProcessStatus::exitedNormally()
  >>> referenced by Test.cpp:240 (/redacted/git/llvm-project/libc/utils/UnitTest/Test.cpp:240)
  >>>               projects/libc/utils/UnitTest/CMakeFiles/LibcUnitTest.dir/Test.cpp.o:(__llvm_libc::testing::Test::testProcessKilled(__llvm_libc::testing::RunContext&, __llvm_libc::testutils::FunctionCaller*, int, char const*, char const*, char const*, unsigned long))
  >>> referenced by Test.cpp:271 (/redacted/git/llvm-project/libc/utils/UnitTest/Test.cpp:271)
  >>>               projects/libc/utils/UnitTest/CMakeFiles/LibcUnitTest.dir/Test.cpp.o:(__llvm_libc::testing::Test::testProcessExits(__llvm_libc::testing::RunContext&, __llvm_libc::testutils::FunctionCaller*, int, char const*, char const*, char const*, unsigned long))
  
  ld.lld: error: undefined symbol: __llvm_libc::testutils::ProcessStatus::getFatalSignal()
  >>> referenced by Test.cpp:248 (/redacted/git/llvm-project/libc/utils/UnitTest/Test.cpp:248)
  >>>               projects/libc/utils/UnitTest/CMakeFiles/LibcUnitTest.dir/Test.cpp.o:(__llvm_libc::testing::Test::testProcessKilled(__llvm_libc::testing::RunContext&, __llvm_libc::testutils::FunctionCaller*, int, char const*, char const*, char const*, unsigned long))
  
  ld.lld: error: undefined symbol: __llvm_libc::testutils::signalAsString(int)
  >>> referenced by Test.cpp:258 (/redacted/git/llvm-project/libc/utils/UnitTest/Test.cpp:258)
  >>>               projects/libc/utils/UnitTest/CMakeFiles/LibcUnitTest.dir/Test.cpp.o:(__llvm_libc::testing::Test::testProcessKilled(__llvm_libc::testing::RunContext&, __llvm_libc::testutils::FunctionCaller*, int, char const*, char const*, char const*, unsigned long))
  >>> referenced by Test.cpp:260 (/redacted/git/llvm-project/libc/utils/UnitTest/Test.cpp:260)
  >>>               projects/libc/utils/UnitTest/CMakeFiles/LibcUnitTest.dir/Test.cpp.o:(__llvm_libc::testing::Test::testProcessKilled(__llvm_libc::testing::RunContext&, __llvm_libc::testutils::FunctionCaller*, int, char const*, char const*, char const*, unsigned long))
  
  ld.lld: error: undefined symbol: __llvm_libc::testutils::ProcessStatus::getExitCode()
  >>> referenced by Test.cpp:280 (/redacted/git/llvm-project/libc/utils/UnitTest/Test.cpp:280)
  >>>               projects/libc/utils/UnitTest/CMakeFiles/LibcUnitTest.dir/Test.cpp.o:(__llvm_libc::testing::Test::testProcessExits(__llvm_libc::testing::RunContext&, __llvm_libc::testutils::FunctionCaller*, int, char const*, char const*, char const*, unsigned long))
  collect2: error: ld returned 1 exit status


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75136/new/

https://reviews.llvm.org/D75136