[libc-commits] [PATCH] D74653: [libc] Add simple implementations of mtx_lock and mtx_unlock.

[Petr Hosek via Phabricator via libc-commits]

phosek added a comment.

Would it be possible to land the enumeration support separately? These are separate changes and I think it'd be cleaner to land them as two commits.



================
Comment at: libc/config/linux/api.td:146
+
+def ThreadsAPI : PublicAPI<"threads.h"> {
+  let TypeDeclarations = [
----------------
Do you plan to graduate these eventually to a common file (and layer Linux on top)? These API aren't Linux specific  and we would like to provide these definitions on other platforms like Fuchsia.


================
Comment at: libc/test/src/threads/linux/mtx_test.cpp:17
+
+int START = 0;
+int MAX = 10000;
----------------
Can you make these `constexpr`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74653/new/

https://reviews.llvm.org/D74653