[libc-commits] [PATCH] D75026: [libc] Add sigprocmask

[Fangrui Song via Phabricator via libc-commits]

MaskRay added inline comments.


================
Comment at: libc/src/signal/linux/sigaddset.cpp:19
+int LLVM_LIBC_ENTRYPOINT(sigaddset)(sigset_t *set, int signum) {
+  if (!set || (unsigned)signum > (8 * sizeof(sigset_t))) {
+    llvmlibc_errno = EINVAL;
----------------
`_NSIG` is expected to be compared.


================
Comment at: libc/src/signal/linux/sigaddset.cpp:20
+  if (!set || (unsigned)signum > (8 * sizeof(sigset_t))) {
+    llvmlibc_errno = EINVAL;
+    return -1;
----------------
(I think I mentioned we don't necessarily invent an `llvmlibc_errno` but the ship has sailed..)


================
Comment at: libc/src/signal/linux/signal.h:23
 // to different architectures.
 struct Sigset {
   sigset_t nativeSigset;
----------------
I believe `struct Sigset` is an overengineering. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75026/new/

https://reviews.llvm.org/D75026