[libc-commits] [PATCH] D74665: [libc] [UnitTest] Create death tests

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra marked an inline comment as done.
sivachandra added a comment.
This revision is now accepted and ready to land.

In D74665#1890131 <https://reviews.llvm.org/D74665#1890131>, @abrachet wrote:

> - Include using "utils/" prefix,
> - Create `strsignal` wrapper, `signalAsString`
> - Rename `InvokeResult` to `ProcessStatus`
> - Rename `invokeFunction` to `invokeInSubprocess`
> - Added missing newline


Thanks for listing the changes.



================
Comment at: libc/utils/UnitTest/Test.h:9
 
-// This file can only include headers from utils/CPP/. No other header should be
-// included.
+#ifndef LLVM_LIBC_UTILS_UNITTEST_H
+#define LLVM_LIBC_UTILS_UNITTEST_H
----------------
Sigh! Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74665/new/

https://reviews.llvm.org/D74665