[libc-commits] [PATCH] D74091: [libc] Lay out framework for fuzzing libc functions.

[Paula Toth via Phabricator via libc-commits]

PaulkaToast marked an inline comment as done.
PaulkaToast added inline comments.


================
Comment at: libc/fuzzing/string/strcpy_fuzz.cpp:22
+  char *dest = new char[size];
+  if (!dest) __builtin_trap();
+
----------------
abrachet wrote:
> Should we be failing when the system can't allocate memory this isn't `__llvm_libc::strcpy`'s fault.
This was discussed with Kotsya in an offline meeting. It is extremely unlikely that the system would be out of memory for the relatively small sizes (by default under 4k bytes though oss-fuzz tests with larger inputs). So a failure here probably indicates something going wrong with the memory allocator which is worth catching as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74091/new/

https://reviews.llvm.org/D74091