[libc-commits] [PATCH] D74652: [libc] Add support library for use with tests.

[Guillaume Chatelet via Phabricator via libc-commits]

gchatelet added a comment.

In D74652#1885864 <https://reviews.llvm.org/D74652#1885864>, @sivachandra wrote:

> Having thought through this patch and its use again, I am currently of the opinion that we should not really be creating equivalents of the library implementations. For example, if we want `abort`, we should use `__llvm_libc::abort`. The `abort` implementation will have its own atomic test and that should be good enough of a confidence to use it in other tests. Likewise, we should be using the `__llvm_libc::thrd_create` and friends instead of using equivalents build over other libraries. We can choose to employ  C++ convenience however - that is, we could implement a thread class using the `__llvm_libc::thrd_*` functions.
>
> WDYT?


Yes that makes sense. For readability it's much better as well since there's no ambiguity on which function gets called.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74652/new/

https://reviews.llvm.org/D74652