[libc-commits] [PATCH] D74948: [libc] Add an optional `NAME` argument to `add_entrypoint_object` rule.

[Siva Chandra via Phabricator via libc-commits]

sivachandra marked an inline comment as done.
sivachandra added inline comments.


================
Comment at: libc/cmake/modules/LLVMLibCRules.cmake:113
     "REDIRECTED" # Optional argument
-    "" # No single value arguments
+    "NAME" # Single value arguments
     "SRCS;HDRS;DEPENDS"  # Multi value arguments
----------------
abrachet wrote:
> Name is also optional, should it's comment say so?
I called them "optional arguments" throughout which is probably a mistake/misnomer. They should actually be called "option arguments" to match the CMake documentation: https://cmake.org/cmake/help/v3.14/command/cmake_parse_arguments.html

Will update separately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74948/new/

https://reviews.llvm.org/D74948