[libc-commits] [PATCH] D74021: Created uChar implementation for libc

Marcus Johnson via libc-commits libc-commits at lists.llvm.org
Thu Feb 6 17:53:00 PST 2020


I’ll do that next time i revise the patch, the weird thing tho is I just copied the header comment from other files in LLVM so not sure why it’d be the wrong size, I’m kinda surprised clang-format changed that part.

> On Feb 6, 2020, at 2:08 PM, Alex Brachet via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> abrachet added inline comments.
> 
> 
> ================
> Comment at: libc/src/uchar/c16rtomb.h:1-2
> -//===----------------- Implementation header for c16rtomb -------------------===//
> +//===----------------- Implementation header for c16rtomb
> +//-------------------===//
> //
> ----------------
> clang-format did this because the line was too long, you should remove a few `-` to shorten it to I think 81 characters it might be 80.
> 
> 
> CHANGES SINCE LAST ACTION
>  https://reviews.llvm.org/D74021/new/
> 
> https://reviews.llvm.org/D74021
> 
> 
> 


More information about the libc-commits mailing list