[libc-commits] [libc] 352cba2 - [libc] add back math.h #include utils/FPUtil/ManipulationFunctions.h

Krasimir Georgiev via libc-commits libc-commits at lists.llvm.org
Thu Dec 17 02:21:56 PST 2020


Author: Krasimir Georgiev
Date: 2020-12-17T11:16:08+01:00
New Revision: 352cba2441c6c4e00f067c9c68358cc0a6a5fffb

URL: https://github.com/llvm/llvm-project/commit/352cba2441c6c4e00f067c9c68358cc0a6a5fffb
DIFF: https://github.com/llvm/llvm-project/commit/352cba2441c6c4e00f067c9c68358cc0a6a5fffb.diff

LOG: [libc] add back math.h #include utils/FPUtil/ManipulationFunctions.h

This partially reverts cee1e7d14f4628d6174b33640d502bff3b54ae45:
  [libc][NFC][Obvious] Remove few unnecessary #include directives in tests.

That commit causes a test failure in our configuration:
[ RUN      ] ILogbTest.SpecialNumbers_ilogb
third_party/llvm/llvm-project/libc/test/src/math/ILogbTest.h:28: FAILURE
      Expected: FP_ILOGBNAN
      Which is: 2147483647
To be equal to: func(__llvm_libc::fputil::FPBits<T>::buildNaN(1))
      Which is: -2147483648

Added: 
    

Modified: 
    libc/utils/FPUtil/ManipulationFunctions.h

Removed: 
    


################################################################################
diff  --git a/libc/utils/FPUtil/ManipulationFunctions.h b/libc/utils/FPUtil/ManipulationFunctions.h
index 79dc741ff629..2bac1b5c229f 100644
--- a/libc/utils/FPUtil/ManipulationFunctions.h
+++ b/libc/utils/FPUtil/ManipulationFunctions.h
@@ -13,10 +13,10 @@
 #include "NearestIntegerOperations.h"
 #include "NormalFloat.h"
 
+#include "include/math.h"
 #include "utils/CPP/TypeTraits.h"
 
 #include <limits.h>
-#include <math.h>
 
 namespace __llvm_libc {
 namespace fputil {


        


More information about the libc-commits mailing list