[libc-commits] [PATCH] D93417: [libc] Refactor WrapperGen to make the flow cleaner.
Michael Jones via Phabricator via libc-commits
libc-commits at lists.llvm.org
Wed Dec 16 15:43:04 PST 2020
michaelrj accepted this revision.
michaelrj added a comment.
This revision is now accepted and ready to land.
accepted with nits
================
Comment at: libc/utils/tools/WrapperGen/Main.cpp:54
+ if (ActionCount != 1) {
+ llvm::PrintFatalError("Exacty one of {--gen-wrapper, --gen-alias} "
+ "should be specified");
----------------
Nit: Exactly
================
Comment at: libc/utils/tools/WrapperGen/Main.cpp:59
+ llvm::PrintFatalError("The options 'mangled-name' and 'mangled-name-file' "
+ "cannot be specified simultaniously.");
+ }
----------------
Nit: simultaneously
================
Comment at: libc/utils/tools/WrapperGen/Main.cpp:68
+ if (MangledNameFile.empty())
+ llvm::PrintFatalError("Atleast one of --mangled-name or "
+ "--mangled-name-file should be specified.");
----------------
Nit: At least
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93417/new/
https://reviews.llvm.org/D93417
More information about the libc-commits
mailing list