[libc-commits] [PATCH] D91831: [libc] Add implementation of hypot.
Tue Ly via Phabricator via libc-commits
libc-commits at lists.llvm.org
Thu Dec 3 07:49:33 PST 2020
lntue marked 2 inline comments as done.
lntue added inline comments.
================
Comment at: libc/utils/FPUtil/Hypot.h:121
+static inline T hypot(T x, T y) {
+ using FPBits_t = FPBits<T>;
+ using UInt_t = typename FPBits<T>::UIntType;
----------------
sivachandra wrote:
> In other functions, we have not used the `_t` suffixes. To be consistent, can you follow the same convention here? If you feel strongly about the `_t` style, you can do a follow up cleanup pass changing everything to follow the `_t` style.
Changed to UIntType
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91831/new/
https://reviews.llvm.org/D91831
More information about the libc-commits
mailing list