[libc-commits] [PATCH] D92137: [libc] add tests to WrapperGen

[Michael Jones via Phabricator via libc-commits]

michaelrj added a comment.

submit comments



================
Comment at: libc/test/utils/tools/WrapperGen/wrappergen_test.cpp:48
+    APIArg.append(TargetOS);
+    APIArg.append("/api.td");
+    ProgPath = llvm::StringRef(ToolPath);
----------------
sivachandra wrote:
> michaelrj wrote:
> > sivachandra wrote:
> > > If you use the test API file approach, you will not need to construct the path to the API file. Just use the path as listed on the command line.
> > I'm not sure what you mean by "use the path as listed on the command line", do you mean create a new command line argument for the api to use? Right now I'm still constructing the path, just in a more simple way.
> Yes, instead of the command line argument which is expecting a path to the libc directory, I am suggesting to use an argument which takes a path to the API file.
I do still need the path to the libc directory since that's an argument for wrappergen, but I have added a new argument for the api file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92137/new/

https://reviews.llvm.org/D92137