[libc-commits] [PATCH] D91551: Initial commit of mktime.

[Fangrui Song via Phabricator via libc-commits]

MaskRay added inline comments.


================
Comment at: libc/config/linux/api.td:41
+   let Decl = [{
+   typedef long time_t;
+  }];
----------------
This may not be a good declaration for 32-bit systems (their support may have lower priority, though, I guess). https://sourceware.org/glibc/wiki/Y2038ProofnessDesign

Then you can avoid all the `sizeof(time_t) == 4` special cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91551/new/

https://reviews.llvm.org/D91551