[libc-commits] [PATCH] D86616: [cmake] Make gtest include directories a part of the library interface

Louis Dionne via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Aug 27 06:38:50 PDT 2020

ldionne added a comment.

In D86616#2241936 <https://reviews.llvm.org/D86616#2241936>, @labath wrote:

> In D86616#2238946 <https://reviews.llvm.org/D86616#2238946>, @ldionne wrote:
>> LGTM, but I'm not an owner for any of the projects touched by this change.
> I picked you because you seemed interested in the overall direction that our cmake support is going :), and I believe that one of our biggest problem with cmake is the lack of a unified direction of where our cmake support is going. (Also, my previous go-to person for that (@beanz), seems to be busy with other stuff these days.)

Yup, I am interested by that indeed :). I just wanted to make it clear my LGTM alone shouldn't be considered enough to commit to these other projects that might have active owners. But it does look like you've got enough approvals for an obviously correct improvement, IMO.

  rG LLVM Github Monorepo



More information about the libc-commits mailing list