[libc-commits] [PATCH] D86616: [cmake] Make gtest include directories a part of the library interface

Pavel Labath via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Aug 26 05:39:09 PDT 2020


labath created this revision.
labath added reviewers: ldionne, beanz.
Herald added subscribers: libc-commits, lldb-commits, dexonsmith, hiraditya, mgorny.
Herald added a reviewer: bollu.
Herald added a reviewer: DavidTruby.
Herald added projects: LLDB, libc-project, LLVM.
labath requested review of this revision.
Herald added a subscriber: JDevlieghere.

This applies the same fix that D84748 <https://reviews.llvm.org/D84748> did for macro definitions.
Appropriate include path is now automatically set for all libraries
which link against gtest targets, which avoids the need to set
include_directories in various parts of the project.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D86616

Files:
  flang/CMakeLists.txt
  libc/benchmarks/CMakeLists.txt
  lldb/unittests/TestingSupport/Symbol/CMakeLists.txt
  llvm/cmake/modules/AddLLVM.cmake
  llvm/lib/Testing/Support/CMakeLists.txt
  llvm/utils/unittest/CMakeLists.txt
  polly/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86616.287943.patch
Type: text/x-patch
Size: 4075 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20200826/9ec5cb83/attachment.bin>


More information about the libc-commits mailing list