[libc-commits] [PATCH] D84725: [libc] Add ULP function to MPFRNumber class to test correctly rounded functions such as SQRT, FMA.

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/utils/MPFRWrapper/MPFRUtils.cpp:180
+  // 1. ULP < 0.5 will imply that the value is correctly rounded.
+  // 2. We expect the mpfr_value and value would be reasonable close,
+  //    and we will provide an upper bound of ULP value for testing.
----------------
May be reword it as:

    We expect that this value and the value to be compared (the |input| argument) are reasonably close ...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84725/new/

https://reviews.llvm.org/D84725