[libc-commits] [PATCH] D85779: [libc] Add strtok_r implementation.

Chris Gyurgyik via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Aug 12 13:56:03 PDT 2020

cgyurgyik marked an inline comment as done.
cgyurgyik added inline comments.

Comment at: libc/src/string/strtok_r.cpp:16
+char *LLVM_LIBC_ENTRYPOINT(strtok_r)(char *src, const char *delimiter_string,
+                                     char **saveptr) {
abrachet wrote:
> sivachandra wrote:
> > Would it make sense to implement `strtok` and `strtok_r` over a common function which is equivalent in functionality to `strtok_r`?
> Making the prototype for this function `restrict` but not the function itself doesn't allow for optimizations. `src` and `delimiter_string` should be marked `__restrict` here and I imagine in a couple of other string functions too
Yeah you're right, I haven't been using `__restrict` at all. I should've probably asked about this at an earlier point, wasn't sure if there was a reason to use it or not. Will fix this here, and other places in future revisions as well.

  rG LLVM Github Monorepo



More information about the libc-commits mailing list