[libc-commits] [PATCH] D85779: [libc] Add strtok_r implementation.
Chris Gyurgyik via Phabricator via libc-commits
libc-commits at lists.llvm.org
Wed Aug 12 09:39:08 PDT 2020
cgyurgyik added inline comments.
================
Comment at: libc/spec/posix.td:16
ConstType ConstCharPtr = ConstType<CharPtr>;
+ RestrictedPtrType RestrictedCharPtr = RestrictedPtrType<CharType>;
+ ConstType ConstRestrictedCharPtr = ConstType<RestrictedCharPtr>;
----------------
sivachandra wrote:
> Other restricted pointer types are named like `RestrictSigSetType`. For consistency, we should use just one style everywhere.
Are you saying at the file level, or the libc level?
For example, in `.../spec/stdc.td`, it is named in the following manner:
`RestrictedPtrType CharRestrictedPtr = RestrictedPtrType<CharType>`. Which would we prefer?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85779/new/
https://reviews.llvm.org/D85779
More information about the libc-commits
mailing list