[libc-commits] [PATCH] D85790: [libc][NFC] Extend <ASSERT|EXPECT>_STR* macros to compare with nullptr.

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/utils/UnitTest/Test.cpp:245-246
                      unsigned long Line) {
+  if (LHS == nullptr || RHS == nullptr)
+    return LHS == RHS;
   return internal::test(Ctx, Cond_EQ, llvm::StringRef(LHS),
----------------
abrachet wrote:
> These should use `internal::test(Ctx, Cond_EQ, LHS, RHS, ...)` so we get nice error messages and are actually reported as failures.
Huh! I am not sure why this diff got uploaded. I am on a different machine today and probably did `arc diff` without committing the changes. I used this diff to find tests which would fail but I have a made more changes over it. Will upload the right diff now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85790/new/

https://reviews.llvm.org/D85790