[libc-commits] [PATCH] D84725: [libc] Add ULP function to MPFRNumber class to test correctly rounded functions such as SQRT, FMA.

Tue Ly via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Aug 5 12:16:42 PDT 2020

lntue added a comment.

In D84725#2183801 <https://reviews.llvm.org/D84725#2183801>, @sivachandra wrote:

> We currently have UnitTest depend on FPUtil. I think that an creates unnecessary dependency for tests which do not need FPUtil for testing. So, a plan could be:
> Instead of `EXPECT_EQ` and friends for floating point numbers, we will decouple UnitTest from FPUtil using matchers implemented in FPUtil. Say, `EXPECT_FP_MATCH` etc.
> WDYT? If you concur, then you need not do the work. I will do it, and you can absorb those changes into this patch.

That sounds good to me.  Let me know when it's ready.  Thanks!

  rG LLVM Github Monorepo



More information about the libc-commits mailing list