[libc-commits] [PATCH] D85059: [libc] Add implementations for isblank, iscntrl, isgraph, ispunct.

Chris Gyurgyik via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Aug 4 11:51:57 PDT 2020


cgyurgyik marked 2 inline comments as done.
cgyurgyik added inline comments.


================
Comment at: libc/src/ctype/ctype_utils.h:31
 
+static inline int isalnum(int c) { return isalpha(c) || isdigit(c); }
+
----------------
sivachandra wrote:
> I should have said said this earlier: seems to me like all the functions in `cytype_utils.h` can take `const unsigned char` argument.
Yeah much cleaner thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85059/new/

https://reviews.llvm.org/D85059



More information about the libc-commits mailing list