[libc-commits] [PATCH] D78886: [libc] Wrap unittests in __llvm_libc namespace. NFC

Alex Brachet via Phabricator via libc-commits libc-commits at lists.llvm.org
Sun Apr 26 18:35:19 PDT 2020


abrachet added a comment.

If the goal is to not need to explicitly use the `__llvm_libc::` prefix in our tests we could change the `TEST` macro to put the class it makes in `__llvm_libc` instead of needing to remember to explicitly put our tests in `__llvm_libc`. Granted it isn't difficult to remember to put new tests in the namespace but I don't think there is any clear advantage to requiring it either.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78886/new/

https://reviews.llvm.org/D78886





More information about the libc-commits mailing list