[libc-commits] [PATCH] D78612: [libc] Add sanitizer instrumentation to the SIMD strlen implementation.

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Apr 22 11:26:08 PDT 2020


sivachandra added a comment.

In D78612#1997367 <https://reviews.llvm.org/D78612#1997367>, @tschuett wrote:

> I am starting to believe that it is better to stay with the slow and safe strlen implementation. Avoid the sanitizer dancing. Spend more energy on adding features. So that people starting using this libc. Then you can use a profiler to find the hot functions.


Making LLVM libc sanitizer friendly is a major goal. So, sorting out sanitizer issues here is not a waste but actually contributing to a feature of LLVM libc.

Sorry, your patch had to be hijacked. But, I felt `strlen` was simple enough to understand and set an example with.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78612/new/

https://reviews.llvm.org/D78612





More information about the libc-commits mailing list