[libc-commits] [PATCH] D78585: [libc][NFC] Cleanup dependencies in src/signal and test/src/signal.

[Alex Brachet via Phabricator via libc-commits]

abrachet accepted this revision.
abrachet added a comment.
This revision is now accepted and ready to land.

LG



================
Comment at: libc/test/src/signal/CMakeLists.txt:24
     libc.src.signal.sigaction
     libc.src.signal.raise
 )
----------------
Nit: we could put raise above sigaction like we do everywhere else.

Not for this patch, but It would be nice if all of our dependencies were alphabetical. I've not done a good job of that. I will look into if there is a programmatic way to have them ordered nicely.


================
Comment at: libc/test/src/signal/CMakeLists.txt:35
+    libc.include.errno
     libc.src.errno.__errno_location
     libc.src.signal.raise
----------------
Probably I should remove the line https://github.com/llvm/llvm-project/blob/master/libc/test/src/signal/sigprocmask_test.cpp#L36 and remove this too. But maybe not appropriate for this patch.


================
Comment at: libc/test/src/signal/CMakeLists.txt:63
     libc.include.signal
     libc.src.errno.__errno_location
     libc.src.signal.raise
----------------
Ditto here and https://github.com/llvm/llvm-project/blob/master/libc/test/src/signal/signal_test.cpp#L22


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78585/new/

https://reviews.llvm.org/D78585