[libc-commits] [PATCH] D78585: [libc][NFC] Cleanup dependencies in src/signal and test/src/signal.

[Siva Chandra via Phabricator via libc-commits]

sivachandra created this revision.
sivachandra added a reviewer: abrachet.
Herald added subscribers: libc-commits, tschuett, mgorny.
Herald added a project: libc-project.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78585

Files:
  libc/src/signal/linux/CMakeLists.txt
  libc/test/src/signal/CMakeLists.txt
  libc/test/src/signal/sigaddset_test.cpp


Index: libc/test/src/signal/sigaddset_test.cpp
===================================================================
--- libc/test/src/signal/sigaddset_test.cpp
+++ libc/test/src/signal/sigaddset_test.cpp
@@ -8,7 +8,6 @@
 
 #include "include/errno.h"
 #include "include/signal.h"
-#include "src/errno/llvmlibc_errno.h"
 #include "src/signal/sigaddset.h"
 
 #include "utils/UnitTest/ErrnoSetterMatcher.h"
Index: libc/test/src/signal/CMakeLists.txt
===================================================================
--- libc/test/src/signal/CMakeLists.txt
+++ libc/test/src/signal/CMakeLists.txt
@@ -18,11 +18,10 @@
   SRCS
     sigaction_test.cpp
   DEPENDS
+    libc.include.errno
+    libc.include.signal
     libc.src.signal.sigaction
     libc.src.signal.raise
-    libc.include.signal
-    libc.include.errno
-    libc.src.errno.__errno_location
 )
 
 add_libc_unittest(
@@ -32,12 +31,12 @@
   SRCS
     sigprocmask_test.cpp
   DEPENDS
-    libc.include.signal
+    libc.include.errno
     libc.src.errno.__errno_location
     libc.src.signal.raise
-    libc.src.signal.sigprocmask
     libc.src.signal.sigaddset
     libc.src.signal.sigemptyset
+    libc.src.signal.sigprocmask
 )
 
 add_libc_unittest(
@@ -47,8 +46,8 @@
   SRCS
     sigaddset_test.cpp
   DEPENDS
+    libc.include.errno
     libc.include.signal
-    libc.src.errno.__errno_location
     libc.src.signal.sigaddset
 )
 
@@ -63,7 +62,6 @@
     libc.include.signal
     libc.src.errno.__errno_location
     libc.src.signal.raise
-    libc.src.signal.sigaction
     libc.src.signal.signal
 )
 
@@ -76,7 +74,6 @@
   DEPENDS
     libc.include.errno
     libc.include.signal
-    libc.src.errno.__errno_location
     libc.src.signal.raise
     libc.src.signal.sigfillset
     libc.src.signal.sigprocmask
@@ -91,7 +88,6 @@
   DEPENDS
     libc.include.errno
     libc.include.signal
-    libc.src.errno.__errno_location
     libc.src.signal.raise
     libc.src.signal.sigdelset
     libc.src.signal.sigfillset
Index: libc/src/signal/linux/CMakeLists.txt
===================================================================
--- libc/src/signal/linux/CMakeLists.txt
+++ libc/src/signal/linux/CMakeLists.txt
@@ -38,10 +38,10 @@
     ../sigaction.h
   DEPENDS
     .__restore
-    .raise
     libc.config.linux.linux_syscall_h
     libc.include.signal
     libc.include.sys_syscall
+    libc.src.errno.__errno_location
 )
 
 add_entrypoint_object(


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78585.259093.patch
Type: text/x-patch
Size: 2406 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20200421/6a841e1b/attachment.bin>