[libc-commits] [PATCH] D77626: [libc] Add very basic stdio FILE and fwrite

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

Did a highlevel pass and dropped a couple of questions. Will do a more fine grained review later in the day.



================
Comment at: libc/src/stdio/fwrite.h:17
+
+size_t fwrite_unlocked(const void *__restrict ptr, size_t size, size_t nmeb,
+                       FILE *__restrict stream);
----------------
Asking for my own knowledge: when/where would an internal unlock version be useful?


================
Comment at: libc/test/config/linux/x86_64/syscall_test.cpp:12
 
-#include <functional>
+namespace __llvm_libc {
+
----------------
Does it make sense to move it utils/CPP? It is incomplete right now, but may be utils/CPP is a more appropriate place.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77626/new/

https://reviews.llvm.org/D77626