[libc-commits] [PATCH] D77533: [libc] Make all header comments consistent.

[Paula Toth via Phabricator via libc-commits]

PaulkaToast added a comment.

In D77533#1964684 <https://reviews.llvm.org/D77533#1964684>, @sivachandra wrote:

> In D77533#1964606 <https://reviews.llvm.org/D77533#1964606>, @abrachet wrote:
>
> > Also, although we only want header files to have the C++ tag, shouldn't we also left justify the text in our .cpp files too?
>
>
> Yes, at least for consistency.
>
> For future integrity, are there are any clang-format/clang-tidy rules which can warn us about such misses? For bad/missing headers guards, there are clang-tidy rules available for LLVM.


I'll look into this, I'm sure a check exists or we can make one.



================
Comment at: libc/utils/CPP/StringRef.h:9-11
+#ifndef LLVM_LIBC_UTILS_CPP_STRINGREF_H
+#define LLVM_LIBC_UTILS_CPP_STRINGREF_H
 
----------------
sivachandra wrote:
> abrachet wrote:
> > We shouldn't remove the include
> Thanks for catching this.
oops! thank you for catching this!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77533/new/

https://reviews.llvm.org/D77533