[libc-commits] [PATCH] D77533: [libc] Make all header comments consistent.
Alex Brachet via Phabricator via libc-commits
libc-commits at lists.llvm.org
Mon Apr 6 10:18:51 PDT 2020
abrachet added inline comments.
================
Comment at: libc/include/__llvm-libc-common.h:1
-//===------- Common definitions for LLVM-libc public header files- --------===//
+//===-- Common definitions for LLVM-libc public header files- -------------===//
//
----------------
Looks like there is a `- ---` which we should make ` ---`. Also should these have `-*- C++ -*-`?
================
Comment at: libc/include/__posix-types.h:1
-//===----------------- Definitions of common POSIX types ------------------===//
+//===-- Definitions of common POSIX types ---------------------------------===//
//
----------------
Same for the C++ tag here.
================
Comment at: libc/include/ctype.h:1
-//===---------------- C standard library header ctype.h -----------------*-===//
+//===-- C standard library header ctype.h -------------------------------*-===//
//
----------------
Here as well, or at least we should remove the `*`
================
Comment at: libc/utils/CPP/StringRef.h:9-11
+#ifndef LLVM_LIBC_UTILS_CPP_STRINGREF_H
+#define LLVM_LIBC_UTILS_CPP_STRINGREF_H
----------------
We shouldn't remove the include
================
Comment at: libc/utils/CPP/StringRef.h:22-23
+
+#endif // LLVM_LIBC_UTILS_CPP_STRINGREF_H
\ No newline at end of file
----------------
Newline
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77533/new/
https://reviews.llvm.org/D77533
More information about the libc-commits
mailing list