[libc-commits] [PATCH] D77340: [libc] Add fully-qualified target names.

[Siva Chandra via Phabricator via libc-commits]

sivachandra created this revision.
sivachandra added reviewers: abrachet, PaulkaToast, phosek.
Herald added subscribers: libc-commits, tschuett, MaskRay, mgorny.
Herald added a project: libc-project.
sivachandra added a comment.

This change implements the topic I brought up many weeks ago: http://lists.llvm.org/pipermail/libc-dev/2020-January/000038.html.

It is probably motivated by my personal preference largely driven by my experience working with GN and Bazel. I am open to listening to opinions from others as it does add verbosity to the target names and can be viewed as a development overhead. But, it also eliminates ambiguity in naming targets, and makes it clear and explicit what each target is about when one reads the target names. More importantly, I like the fact the we can now set up directory specific build and run targets as I explained in the above post (for example, `test.src.signal.__build__` and `test.src.signal.__run__`.)


Only targets setup by the special LLVM libc rules now have fully
qualified names. The naming style is similar to fully qualified names in
Python.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77340

Files:
  libc/CMakeLists.txt
  libc/cmake/modules/LLVMLibCRules.cmake
  libc/cmake/modules/LLVMLibCTargetNameUtils.cmake
  libc/config/linux/CMakeLists.txt
  libc/fuzzing/string/CMakeLists.txt
  libc/include/CMakeLists.txt
  libc/lib/CMakeLists.txt
  libc/loader/linux/CMakeLists.txt
  libc/loader/linux/x86_64/CMakeLists.txt
  libc/src/__support/CMakeLists.txt
  libc/src/assert/CMakeLists.txt
  libc/src/signal/CMakeLists.txt
  libc/src/signal/linux/CMakeLists.txt
  libc/src/stdlib/CMakeLists.txt
  libc/src/stdlib/linux/CMakeLists.txt
  libc/src/string/CMakeLists.txt
  libc/src/string/memory_utils/CMakeLists.txt
  libc/src/sys/mman/CMakeLists.txt
  libc/src/sys/mman/linux/CMakeLists.txt
  libc/src/threads/CMakeLists.txt
  libc/src/threads/linux/CMakeLists.txt
  libc/test/config/linux/x86_64/CMakeLists.txt
  libc/test/loader/CMakeLists.txt
  libc/test/loader/linux/CMakeLists.txt
  libc/test/src/assert/CMakeLists.txt
  libc/test/src/errno/CMakeLists.txt
  libc/test/src/signal/CMakeLists.txt
  libc/test/src/stdlib/CMakeLists.txt
  libc/test/src/string/CMakeLists.txt
  libc/test/src/string/memory_utils/CMakeLists.txt
  libc/test/src/sys/mman/linux/CMakeLists.txt
  libc/test/src/threads/CMakeLists.txt
  libc/utils/UnitTest/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77340.254632.patch
Type: text/x-patch
Size: 41376 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20200402/910c4372/attachment-0001.bin>