[libc-commits] [PATCH] D77277: [libc] Fix memcpy to adhere to qualified calls.

[Paula Toth via Phabricator via libc-commits]

PaulkaToast added inline comments.


================
Comment at: libc/src/math/round_redirector.cpp:17
+  // Call system round since llvm-libc round is yet to be implemented.
+  return ::round(x); // LIBC-NOLINT
 }
----------------
sivachandra wrote:
> Redirected calls should not need NOLINT annotations. Calling into system libc is correct by design. What is failing without this NOLINT annotation?
You're right, redirectors do this by design. Removed comment and nolint.


================
Comment at: libc/src/string/strcpy.cpp:18
+  return reinterpret_cast<char *>(
+      __llvm_libc::memcpy(dest, src, ::strlen(src) + 1));
 }
----------------
sivachandra wrote:
> abrachet wrote:
> > Should we wait for D77279 to use `__llvm_libc::strlen`?
> Yes. Wait for D77279 and absorb the change here.
Gotcha (:


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77277/new/

https://reviews.llvm.org/D77277