[libc-commits] [PATCH] D69020: Illustrate a redirector using the example of round function from math.h.
Jake Ehrlich via Phabricator via libc-commits
libc-commits at lists.llvm.org
Fri Oct 25 14:41:42 PDT 2019
jakehehrlich added a comment.
I've missed some emails and the round table at llvm. Could you describe more about why this mechanism for redirecting is used? It seems to me that there should be a way for `LLVM_LIBC_ENTRYPOINT(round)` to be an alias for `::round` rather than requiring two (likely tail) calls here. Could you motivate this mechanism?
================
Comment at: libc/docs/redirectors.rst:33
+
+Let us take the ``round`` function from ``math.h`` as an example to see how it's
+implementation looks like when it just redirects to the ``round`` function from
----------------
"...to see how it's..." should be "...to see what it's..."
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69020/new/
https://reviews.llvm.org/D69020
More information about the libc-commits
mailing list