[libc-commits] [PATCH] D69421: [libc] Header generation scheme.

[Alex Brachet via Phabricator via libc-commits]

abrachet accepted this revision.
abrachet added a comment.
This revision is now accepted and ready to land.

LGTM I see no problems from what is here. I'd also like to say that the emphasis on writing docs for all of this is something I'm really happy to see.
I look forward to seeing how the generator works. I am also cautiously optimistic about how well this mechanism will work to create more exotic functions and typedefs. `signal(3)` and `jmp_buf` will surely be interesting interesting :)



================
Comment at: libc/spec/stdc.td:11
+  let Functions = [
+    Function<"strcpy", "char *", ["char *__restrict", "const char *__restrict"]>
+  ];
----------------
Nit: Might be worth it to add strcat and acosl  because they are in header_conf.td.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69421/new/

https://reviews.llvm.org/D69421