[libc-commits] [PATCH] D69020: Illustrate a redirector using the example of round function from math.h.

[Fangrui Song via Phabricator via libc-commits]

MaskRay added inline comments.


================
Comment at: libc/cmake/modules/LLVMLibCRules.cmake:270
+  # TODO: Call the linker explicitly instead of calling the compiler driver to
+  # prevent DT_NEEDED on C++ runtime.
+  add_library(
----------------
You may need something like `-nostdlib`


================
Comment at: libc/cmake/modules/LLVMLibCRules.cmake:281
+    PRIVATE
+    -lc -lm
+  )
----------------
`-lc` is implicit unless `-nolibc` (clang-only).

`-nolibc` is implied by `-nodefaultlibs`. `-nodefaultlibs` is implied by `-nostdlib`.


================
Comment at: libc/src/math/round/round.h:14
+
+double round(double x);
+
----------------
Delete `x`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69020/new/

https://reviews.llvm.org/D69020