[libc-commits] [PATCH] D67867: [libc] Add few docs and implementation of strcpy and strcat.

[Nathan Chancellor via Phabricator via libc-commits]

nathanchance added a comment.

Just as an FYI, this patch breaks `LLVM_INCLUDE_TESTS=OFF` for me:

  $ cmake -GNinja -DPYTHON_EXECUTABLE=$(command -v python3)  -DLLVM_ENABLE_PROJECTS=all ../llvm
  ...
  -- Configuring done
  -- Generating done
  -- Build files have been written to: /home/nathan/src/llvm-project/build
  
  $ cd .. && rm -rf build && mkdir -p build && cd build 
  
  $ cmake -GNinja -DPYTHON_EXECUTABLE=$(command -v python3) -DLLVM_ENABLE_PROJECTS=all -DLLVM_INCLUDE_TESTS=OFF ../llvm
  ...
  -- Configuring done
  CMake Error at /home/nathan/src/llvm-project/libc/cmake/modules/LLVMLibCRules.cmake:264 (add_dependencies):
    The dependency target "gtest" of target "strcpy_test" does not exist.
  Call Stack (most recent call first):
    /home/nathan/src/llvm-project/libc/src/string/strcpy/CMakeLists.txt:11 (add_libc_unittest)
  
  
  CMake Error at /home/nathan/src/llvm-project/libc/cmake/modules/LLVMLibCRules.cmake:264 (add_dependencies):
    The dependency target "gtest" of target "strcat_test" does not exist.
  Call Stack (most recent call first):
    /home/nathan/src/llvm-project/libc/src/string/strcat/CMakeLists.txt:12 (add_libc_unittest)
  
  
  -- Generating done
  -- Build files have been written to: /home/nathan/src/llvm-project/build
  
  $ git revert -n 4380647e79bd80af1ebf6191c2d6629855ccf556
  
  $ cd .. && rm -rf build && mkdir -p build && cd build 
  
  $ cmake -GNinja -DPYTHON_EXECUTABLE=$(command -v python3) -DLLVM_ENABLE_PROJECTS=all -DLLVM_INCLUDE_TESTS=OFF ../llvm
  ...
  -- Configuring done
  -- Generating done
  -- Build files have been written to: /home/nathan/src/llvm-project/build

This is as of r374191 <https://github.com/llvm/llvm-project/commit/4c4df441860c9c119ad063bbdd6b5fc11c2dc1d8>.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67867/new/

https://reviews.llvm.org/D67867