[libc-commits] [PATCH] D67867: [libc] Add few docs and implementation of strcpy and strcat.

[Fangrui Song via Phabricator via libc-commits]

MaskRay added a comment.

The commit was done in a hurry. Many points raised in the review process were just shrugged off.

- Proper cmake review
- Detailed summary. The commit message should at least reference some previous discussions on the mailing list, especially this is a brand new project.
- The llvm-objcopy issue definitely needs more consideration. This may interfere badly with instrumentation tools, which is a selling point of the llvm libc.
- Why `__llvm_libc` is necessary is not well explained.
- Some necessary options `-ffreestanding -nostdinc` are absent.
- C++ should not get `#define __restrict restrict`
- ...

This is a post-commit review anyway so many points are probably moot.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67867/new/

https://reviews.llvm.org/D67867