[libc-commits] [PATCH] D67867: [libc] Add few docs and implementation of strcpy and strcat.
Siva Chandra via Phabricator via libc-commits
libc-commits at lists.llvm.org
Thu Oct 3 22:12:34 PDT 2019
sivachandra added a comment.
Herald added a project: libc-project.
Herald added a subscriber: libc-commits.
In D67867#1692484 <https://reviews.llvm.org/D67867#1692484>, @MaskRay wrote:
> My earlier question is about why we need the namespace `__llvm_libc` at all. From `libc/src/string/strcat/strcat_test.cpp` I conclude it is for unit testing in an environment that already has a libc (gtest). This should probably be documented.
Documentation is a good idea. At this point, we want the implementation to be as much as possible like a normal C++ library and allow mixing this libc with other libcs in various scenarios like unit testing, differential testing etc. This is the first patch; I am sure a lot will change in the coming months. I want to write up things like this after we at least get a clear idea of the Windows strategy (I am working on it).
> https://reviews.llvm.org/D67867#1686834 mentioned that the objcopy scheme will break the `st_size` fields of symbols.
Yes, st_size is broken in the sense that it doesn't show the size of the aliasee. But, it almost never matters practically.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67867/new/
https://reviews.llvm.org/D67867
More information about the libc-commits
mailing list