[libc-commits] [PATCH] D70197: [libc] Add a TableGen based header generator.

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Nov 20 12:47:28 PST 2019

sivachandra marked 3 inline comments as done.
sivachandra added inline comments.

Comment at: libc/utils/HdrGen/Command.h:29
+  class Status {
+    bool Success;
abrachet wrote:
> sivachandra wrote:
> > abrachet wrote:
> > > Why not `llvm::Error`?
> > IIUC, using llvm::Error will require defining error codes etc. I feel that is an overkill for the use case here which just requires a pass/fail status + a message.
> I think adding those includes is worth it because it increases readability, people are very familiar with `llvm::Error` and won't need to go searching for what `Status` is like I had to. Up to you.
I got rid of this class and introduced another one which encapsulates an SMLoc and SourceMgr.

  rG LLVM Github Monorepo



More information about the libc-commits mailing list