[libc-commits] [PATCH] D71094: [libc] Add implementation of errno and define the other macros of errno.h.

[Siva Chandra via Phabricator via libc-commits]

sivachandra marked 2 inline comments as done.
sivachandra added inline comments.


================
Comment at: libc/include/errno.h.def:14
+
+%%public_api()
+
----------------
abrachet wrote:
> glibc has an ifdef block around the C definitions to exclude them if `ASSEMBLER` is defined so that only the E* macros are exposed to assembly files which want them. I would imagine no one is including C's `errno.h` instead of `linux/errno.h`in assembly source, but I figured I would bring it up. https://code.woboq.org/userspace/glibc/stdlib/errno.h.html#32
> 
I prefer to add anything like that on an "as needed" basis.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71094/new/

https://reviews.llvm.org/D71094