[flang-dev] [classic-flang] RFC for pull request validation process for Classic Flang

[Gary Klimowicz via flang-dev]

The goal of the Flang Community Pull Request Process is to ensure that only well-tested patches are incorporated into the github.com/flang-compiler/flang master branch. Most Fortran tests, benchmarks, and applications are proprietary, and therefore are not part of the flang public test suite, and these are the tests that need to be run in order to continue to maintain the quality of flang.

To that end, a group of individuals and organizations have volunteered to test and discuss pull requests. The process allows just two assenting votes before a gatekeeper is allowed to merge a pull request into the master branch.

Current volunteers (reviewers) include:

  *   Kiran Chandramohan, Rich Barton, Carol Concatto, Andrzej Warzynski (Arm)
  *   Gary Klimowicz, Jie Li, Varun Jayathirtha (NVIDIA)
  *   Shivaram Rao (AMD)

If you would like to be a volunteer, please submit your request to flang-dev.

Current gatekeepers:

  *   Gary Klimowicz and Steve Scalpone, NVIDIA
  *   Kiran Chandramohan and Rich Barton, Arm
  *   Shivaram Rao, AMD

Gatekeepers are chosen because of their involvement in flang development. If you would like to be a gatekeeper, please submit your request to flang-dev.

The proposed process:

  1.  Each pull request has an owner. The owner is typically the person who created the pull request; however, anyone may adopt a pull request. The owner is responsible for making sure the PR can be merged with master and tests cleanly (including new tests). The owner is also responsible for handling feedback during the review and testing process. The owner can signal that a patch is ready for review using flang-dev or the flang slack channel.



  1.  As part of the review process, the reviewers agree to apply the patch and run their internal test suites with it, and then give feedback on the patch. Note that feedback might be limited to simply pass or fail because of restrictions on the test suites.


  1.  Volunteer testers and reviewers offer feedback on the PR in the GitHub discussion on the pull request.


  1.  Even for the most trivial patch, at least two volunteers must apply the patch, run their internal tests, and give feedback on the patch. The patch should be run on at least Arm, x86 and OpenPOWER on LLVM 9.0.




  1.  When two reviewers complete their testing and approve the patch, a gatekeeper can merge the patch. Note that a gatekeeper is not mandated to merge a patch at this point if the discussion and consensus process has not run its course.

Please respond to this thread if you have suggestions or questions.

Gary Klimowicz
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/flang-dev/attachments/20200618/93f3d744/attachment.html>