[flang-dev] Code formatting alignment with LLVM

[David Truby via flang-dev]

Hi Johannes,

Hopefully I can clarify: the supposed issue here is that the alignment of the comments on lines 321,322 on the left and 323, 324 on the right have changed, which makes those lines appear as having been changed where they actually haven't other than formatting due to other line changes.

Does that make some sense?

David

________________________________
From: Johannes Doerfert
Sent: Thursday, 13 February 2020 21:37
To: David Truby
Cc: David Truby via flang-dev
Subject: Re: [flang-dev] Code formatting alignment with LLVM

On 02/13, David Truby wrote:
> Hi Johannes,
> I didn't realise we could upload the same diff on Phabricator to look at, that's really helpful!
>
> I believe we are looking at lines 320-324 of PFTBuilder.h.

I thought we talk about alignment "issues" and this seems not to be one.


> I don't see a real significant difference in the way this is displayed I suppose. Phabricator doesn't pick up that lines 323 and 324 on the right are the same as 312, 322 on the left sans formatting.
> However, I think that even if the formatting was the same Phabricator would display this in the same way as that's just how it displays diffs?
>
> Maybe Tim can comment on what he thinks of this?
>
> Thanks
> David Truby
>
>
> ________________________________
> From: Johannes Doerfert
> Sent: Thursday, 13 February 2020 21:27
> To: David Truby
> Cc: David Truby via flang-dev
> Subject: Re: [flang-dev] Code formatting alignment with LLVM
>
> On 02/13, David Truby via flang-dev wrote:
> > Hi all,
> >
> > Tim Kieth from Nvidia has provided a specific example from the recent
> > FIR pull request where the indentation rules caused spurious diffs
> > (see this comment:
> > https://github.com/flang-compiler/f18/pull/945#issuecomment-585856610).
> >
> > I'm curious if this is also something that shows up badly in
> > Phabricator or if that has a better way of showing diffs involving
> > whitespace. Is anyone familiar enough with Phabricator to comment on
> > this? I wonder if Phabricator might just be better at handling code
> > reviews of this ilk better, meaning that this problem is less visible
> > to clang/llvm developers.
> >
>
> Here is the diff:
> https://reviews.llvm.org/differential/diff/244525/
>
> What line numbers are we looking at again?
>
>
> > Thanks
> > David Truby
> >
> > ________________________________
> > From: flang-dev <flang-dev-bounces at lists.llvm.org> on behalf of David Truby via flang-dev <flang-dev at lists.llvm.org>
> > Sent: 11 February 2020 10:20
> > To: flang-dev at lists.llvm.org <flang-dev at lists.llvm.org>
> > Subject: [flang-dev] Code formatting alignment with LLVM
> >
> > Hi all,
> >
> > We have been having a discussion on the GitHub issue tracker about code formatting (and specifically clang-format settings) and whether to align closer with the rest of the project, which you can find here: https://github.com/flang-compiler/f18/pull/945. Since the discussion there hasn’t moved much recently I’d like to start a discussion here so we can get input from a wider group of people.
> >
> > My opinion is that regardless of technical preferences we shouldn’t diverge from the style of the rest of the project as much as we currently do, or at least if we want to do that then we should have a discussion with the wider community about whether that is acceptable to them.
> >
> > Does anyone else have any input on this?
> >
> > Thanks
> > David Truby
>
> > _______________________________________________
> > flang-dev mailing list
> > flang-dev at lists.llvm.org
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/flang-dev
>
>
> --
>
> Johannes Doerfert
> Researcher
>
> Argonne National Laboratory
> Lemont, IL 60439, USA
>
> jdoerfert at anl.gov

--

Johannes Doerfert
Researcher

Argonne National Laboratory
Lemont, IL 60439, USA

jdoerfert at anl.gov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/flang-dev/attachments/20200213/42e2ad47/attachment-0001.html>