[flang-commits] [clang] [flang] [llvm] [polly] [Plugins] Pass arguments to a pass plugin with -plugin-arg (PR #226773)

[Alexis Engelke via flang-commits]

================
@@ -33,7 +34,7 @@ class TargetMachine;
 /// against that of the plugin. A mismatch is an error. The supported version
 /// will be incremented for ABI-breaking changes to the \c PassPluginLibraryInfo
 /// struct, i.e. when callbacks are added, removed, or reordered.
-#define LLVM_PLUGIN_API_VERSION 2
+#define LLVM_PLUGIN_API_VERSION 3
----------------
aengelke wrote:

(Unrelated side remark: this version number is completely pointless, because plugins use the unstable C++ ABI. This really ought to be LLVM_VERSION_MAJOR*10+LLVM_VERSION_MINOR or similar. It is also pointless because if a mismatch is detected, UB has already occurred as the plugin possibly wrote a larger struct, destroying the stack frame.)

https://github.com/llvm/llvm-project/pull/226773