[flang-commits] [flang] [llvm] [mlir] [OpenMP] Honor barrier and last iteration flags in loop lowering (PR #224040)

[Sergio Afonso via flang-commits]

================
@@ -260,3 +263,15 @@ subroutine omp_taskloop_lastprivate()
    ! CHECK:  omp.terminator
    !$omp end taskloop
 end subroutine omp_taskloop_lastprivate
+
+! CHECK-LABEL:  func @_QPomp_taskloop_first_and_lastprivate()
+subroutine omp_taskloop_first_and_lastprivate()
+   integer x
+   x = 0
+   ! CHECK:  omp.taskloop.context private(@[[FIRST_LAST_PRIVATE_X]] {{.*}}) {
----------------
skatrak wrote:

I think it would be good to make it explicit with a `CHECK-NOT`. Otherwise, if for some reason the barrier was added again, it would be easy to assume the test needed an update rather than noticing that a bug was introduced.

https://github.com/llvm/llvm-project/pull/224040