[flang-commits] [flang] [flang] Diagnose ENUM BIND(C) value overflow (PR #224388)

via flang-commits flang-commits at lists.llvm.org
Mon Sep 21 08:55:59 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- flang/lib/Semantics/resolve-names.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/flang/lib/Semantics/resolve-names.cpp b/flang/lib/Semantics/resolve-names.cpp
index 03be486ba..0e96a4d71 100644
--- a/flang/lib/Semantics/resolve-names.cpp
+++ b/flang/lib/Semantics/resolve-names.cpp
@@ -6384,10 +6384,8 @@ bool DeclarationVisitor::Pre(const parser::NamedConstant &x) {
 
 bool DeclarationVisitor::Pre(const parser::Enumerator &enumerator) {
   const parser::Name &name{std::get<parser::NamedConstant>(enumerator.t).v};
-  constexpr std::int64_t minCInt{
-      std::numeric_limits<std::int32_t>::min()};
-  constexpr std::int64_t maxCInt{
-      std::numeric_limits<std::int32_t>::max()};
+  constexpr std::int64_t minCInt{std::numeric_limits<std::int32_t>::min()};
+  constexpr std::int64_t maxCInt{std::numeric_limits<std::int32_t>::max()};
   Symbol *symbol{FindInScope(name)};
   if (symbol && !symbol->has<UnknownDetails>()) {
     // Contrary to named constants appearing in a PARAMETER statement,
@@ -6446,8 +6444,8 @@ bool DeclarationVisitor::Pre(const parser::Enumerator &enumerator) {
 
   if (symbol) {
     if (enumerationState_.value) {
-      symbol->get<ObjectEntityDetails>().set_init(SomeExpr{
-          evaluate::Expr<evaluate::CInteger>{
+      symbol->get<ObjectEntityDetails>().set_init(
+          SomeExpr{evaluate::Expr<evaluate::CInteger>{
               static_cast<evaluate::CInteger::Scalar>(
                   *enumerationState_.value)}});
     } else {

``````````

</details>


https://github.com/llvm/llvm-project/pull/224388


More information about the flang-commits mailing list