[flang-commits] [flang] [flang] Fix TRANSFER into derived type with tail padding (PR #223814)

[via flang-commits]

================
@@ -1552,15 +1472,24 @@ void fir::factory::genRecordAssignment(fir::FirOpBuilder &builder,
     return;
   }
 
-  // Otherwise, the derived type has compile time constant size and for which
-  // the component by component assignment can be replaced by a memory copy.
-  // Since we do not know the size of the derived type in lowering, do a
-  // component by component assignment. Note that a single fir.load/fir.store
-  // could be used on "small" record types, but as the type size grows, this
-  // leads to issues in LLVM (long compile times, long IR files, and even
-  // asserts at some point). Since there is no good size boundary, just always
-  // use component by component assignment here.
-  genComponentByComponentAssignment(builder, loc, lhs, rhs, isTemporaryLHS);
+  // Otherwise, the derived type has compile time constant size, no
+  // allocatable components, and no user-defined assignment. The size of the
+  // type is not known at this point in lowering, but fir.copy defers the size
+  // computation to codegen where the LLVM data layout is available. That allows
+  // it to copy the full allocated storage including any ABI tail-padding bytes,
+  // which a field-by-field copy would silently skip. Preserving those bytes
+  // matters for SEQUENCE types whose storage is reinterpreted via EQUIVALENCE
+  // or TRANSFER.
+  mlir::Value fromAddr = fir::getBase(rhs);
+  mlir::Value toAddr = fir::getBase(lhs);
+  // Ensure we have raw ref<RecordType> pointers for fir.copy.
+  auto refTy = builder.getRefType(recTy);
+  if (fromAddr.getType() != refTy)
+    fromAddr = builder.createConvert(loc, refTy, fromAddr);
+  if (toAddr.getType() != refTy)
+    toAddr = builder.createConvert(loc, refTy, toAddr);
+  // disjoint == true at this point (guaranteed by the condition above).
----------------
MattPD wrote:

The new self-assignment CHECK still accepts `fir.copy %arg0 to %arg0 no_overlap : ...`. The destination pattern `%{{.*}}` also matches ` no_overlap`, so the following `CHECK-NOT` begins after the attribute. The default CHECK lines pass on the current output. They also pass on the output from [the initial implementation](https://github.com/llvm/llvm-project/commit/dad1d47da0eaf7d88e534092beea780f4d4bdf92), which still carries the attribute.

Could the check capture the function argument as `%[[A]]` and require `fir.copy %[[A]] to %[[A]] :`? That form matches the current output and fails on the earlier output. The disjoint control case can stay as it is.

https://github.com/llvm/llvm-project/pull/223814