[flang-commits] [flang] [mlir] [mlir][LLVM] Add LLVM::getLoopAnnotationAttrName() (PR #224060)

[Scott Manley via flang-commits]

================
@@ -114,4 +114,16 @@ verifyModuleFlagValue(StringAttr key, Attribute value,
 #define GET_ATTRDEF_CLASSES
 #include "mlir/Dialect/LLVMIR/LLVMOpsAttrDefs.h.inc"
 
+namespace mlir {
+namespace LLVM {
+
+/// Canonical name used when attaching LoopAnnotationAttr as a discardable
+/// attribute on operations that do not declare it inherently.
+inline constexpr llvm::StringLiteral getLoopAnnotationAttrName() {
----------------
rscottmanley wrote:

I feel like this change makes it more consistent with the rest of the codebase. If it makes sense to change it, there should be a more unified effort to change all of them

https://github.com/llvm/llvm-project/pull/224060