[flang-commits] [flang] [mlir] [Flang][OpenMP] Support iterator modifier in map and motion clauses (PR #197757)

[via flang-commits]

https://github.com/MattPD commented:

Verified against dcc6653c5481c903212c152d881c86335dcaea86.

I am noting one pre-existing issue for tracking, not as a request against this PR: A USE-renamed mapper loses its identity. The module declares `!$omp declare mapper(m: t :: v) map(to: v%a)`, and the consumer writes `use that_module, only: t, mm => m`. With that rename, `target update to(mapper(mm): x)` emits no `mapper(@...)` at the parent commit 82004b0 or at dcc6653. The unrenamed `mapper(m)` emits `mapper(@_QQMthat_modulem)`. The iterated spelling `to(mapper(mm), iterator(j=1:4): x(j))` inherits the same silent fallback to the implicit map.

`getMapperIdentifier` mangles the local name `mm` with the declaring module, so the lookup misses the symbol mangled from `m`. @TIFitis, was the lookup added in #167903 intended to support USE-renamed mappers?

https://github.com/llvm/llvm-project/pull/197757