[flang-commits] [flang] [llvm] [Flang] Introduce *Value classes with unittests (PR #216958)

[Eugene Epshteyn via flang-commits]

https://github.com/eugeneepshteyn commented:

Another interesting comment from AI agent. Specifically, it's talking about this function in the original implementation:
```c++
  // ICHAR also implements IACHAR under assumption that character encodings
  // contain ASCII
  static std::int64_t ICHAR(const Character &c) {
    CHECK(c.length() == 1);
    // Convert first to an unsigned integer type to avoid sign extension
    return static_cast<common::HostUnsignedIntType<(8 * KIND)>>(c[0]);
  }
```

https://github.com/llvm/llvm-project/pull/216958